Refactor: Extract recommendation logic into focused methods#152
Closed
Refactor: Extract recommendation logic into focused methods#152
Conversation
Co-authored-by: neibler <87866961+neibler@users.noreply.github.com>
Co-authored-by: neibler <87866961+neibler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor home screen recommended products and brands
Refactor: Extract recommendation logic into focused methods
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaks down monolithic recommendation methods in
ProductServiceandBrandServiceinto composable units.Changes
ProductService
Extracted 100-line
getPersonalizedRecommendations()into focused methods:collectBaseProductIds()- aggregates view history + cart itemscalculateRecommendationFilter()- computes category/price boundscollectExcludeProductIds()- gathers purchased + base productsfetchRecommendedProducts()- executes filtered queryfillWithPopularProducts()- backfills when recommendations < requested sizeIntroduced
RecommendationFilterrecord to encapsulate filter criteria:BrandService
Extracted nested stream operations into methods:
buildBrandRecommendResponse()- assembles brand + products responsefetchBrandProducts()- retrieves random products per brandBRAND_PRODUCT_COUNTconstant (was magic number6)No Behavioral Changes
All endpoints maintain identical functionality and API contracts.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.